Modifications in async_api to make it valid definition #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckeshava
reviewed
Jul 18, 2024
| $RefParser | ||
| .dereference('./async_api/websocket_api.yaml') | ||
| .then((schema) => { | ||
| fs.writeFileSync('dist/async_api.json', JSON.stringify(schema, null, 2)) |
There was a problem hiding this comment.
are we not supporting API V2 by default? I believe all the validators have switched to rippled API v2 now
There was a problem hiding this comment.
This is just a script, we can add v2 — can you make a follow up PR?
| @@ -3,6 +3,7 @@ | |||
| "template": "node addRequestTemplate.js" | |||
| }, | |||
| "devDependencies": { | |||
| "json-schema-ref-parser": "^9.0.9", | |||
There was a problem hiding this comment.
We should use the better maintained version of this library -- https://www.npmjs.com/package/@apidevtools/json-schema-ref-parser
This was the suggestion of the library author on the npm page
There was a problem hiding this comment.
Sounds good I’ll add that as a follow up
|
FYI, I've updated the V2 spec file with these updates: 460ba5a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.