-
Notifications
You must be signed in to change notification settings - Fork 653
feat(iceberg): refine iceberg table column datatype and name. #19690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iceberg): refine iceberg table column datatype and name. #19690
Conversation
…ix_column_data_types_for_iceberg_engine_table
…ix_column_data_types_for_iceberg_engine_table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
input_ref | ||
} | ||
} else { | ||
// fields like `_rw_timestamp`, would not be found in source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any other example?
I am think whether we should bail!
if a column is not found in the Iceberg source and it's not _rw_timestamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think _rw_timestamp
is the only one that would hit this branch.
I am think whether we should bail! if a column is not found in the Iceberg source and it's not _rw_timestamp
This is the planner's beginning, so we must select all columns from a table (including the _rw_timestamp
) unless we move this conversion to the end of the optimizer (after column pruning).
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
jsonb
,smallint
,serial
, and so on)._row_id
as a reserved column name for row lineage, so if the table without primary key, we can't use_row_id
directly for iceberg, this PR change it to_risingwave_iceberg_row_id
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.