testscript: protect against no-op uses of cmp #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cueckoo
pushed a commit
to cue-lang/cue-trybot
that referenced
this pull request
Apr 9, 2025
We were doing `cmp foo.go foo.go` rather than `cmp foo.go foo.go.want`, which always succeeded, and caused CUE_UPDATE=1 to not update the "want" files at all. Fix that, and update the generated files to actually reflect what we do. This stumped and annoyed me enough that I also sent a change to testscript to make such silly mistakes an error: rogpeppe/go-internal#295 Signed-off-by: Daniel Martí <[email protected]> Change-Id: If24c6e2439a828c9da7cf3028c61126e899bd96c Dispatch-Trailer: {"type":"trybot","CL":1213229,"patchset":1,"ref":"refs/changes/29/1213229/1","targetBranch":"master"}
cueckoo
pushed a commit
to cue-lang/cue-trybot
that referenced
this pull request
Apr 9, 2025
We were doing `cmp foo.go foo.go` rather than `cmp foo.go foo.go.want`, which always succeeded, and caused CUE_UPDATE=1 to not update the "want" files at all. Fix that, and update the generated files to actually reflect what we do. This stumped and annoyed me enough that I also sent a change to testscript to make such silly mistakes an error: rogpeppe/go-internal#295 Signed-off-by: Daniel Martí <[email protected]> Change-Id: If24c6e2439a828c9da7cf3028c61126e899bd96c
rogpeppe
approved these changes
Apr 9, 2025
cueckoo
pushed a commit
to cue-lang/cue
that referenced
this pull request
Apr 10, 2025
We were doing `cmp foo.go foo.go` rather than `cmp foo.go foo.go.want`, which always succeeded, and caused CUE_UPDATE=1 to not update the "want" files at all. Fix that, and update the generated files to actually reflect what we do. This stumped and annoyed me enough that I also sent a change to testscript to make such silly mistakes an error: rogpeppe/go-internal#295 Signed-off-by: Daniel Martí <[email protected]> Change-Id: If24c6e2439a828c9da7cf3028c61126e899bd96c Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1213229 Unity-Result: CUE porcuepine <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Reviewed-by: Roger Peppe <[email protected]>
This just bit me and it stumped me for a solid five minutes. I'm sure I've made the mistake at least one more time elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)