🩹 Handle response headers before shutting down #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting cookies when sending the response happens too late in the
shutdown
hook.It might be worth looking into using
Response::sendContent()
overResponse::send()
and then manually filtering/handling appropriate headers in thesend_headers
hook instead.Ideally we'd filter out headers such as
Cache-Control
which causes unexpected behavior as seen in #456.EDIT: I went ahead and implemented the above.