-
Notifications
You must be signed in to change notification settings - Fork 347
[CM] Add controller_manager activity topic #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Add controller_manager activity topic #2006
Conversation
dbe3071
to
6768145
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2006 +/- ##
==========================================
+ Coverage 89.54% 89.56% +0.02%
==========================================
Files 139 139
Lines 15125 15195 +70
Branches 1283 1290 +7
==========================================
+ Hits 13543 13609 +66
+ Misses 1096 1094 -2
- Partials 486 492 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great addition. Should we also add a publisher section here describing this?
https://control.ros.org/rolling/doc/ros2_control/controller_manager/doc/userdoc.html#subscribers
Actually, I want to document all the Services and Publishers from the controller manager. I don't know if I have to do it in this PR or a separate PR. What's your opinion @christophfroehlich |
controller_manager/include/controller_manager/controller_manager.hpp
Outdated
Show resolved
Hide resolved
please add the docs for this new publisher with this PR. |
@christophfroehlich done! 👍🏾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
resource_manager_->set_on_component_state_switch_callback( | ||
std::bind(&ControllerManager::publish_activity, this)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this is easier to integrate now but shouldn't we simply make these part of the constructors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, when we branch off, we will certainly do that :)
This pull request is in conflict. Could you fix it @saikishor? |
5641d8d
As discussed in the ros2_control WG meeting on 15th Jan 2025
I've added a topic to the CM inorder to publish information on changes in the CM. This is quite useful to have when developing applications that need to be dynamic enough with the changes in CM. Right now, the only way is to spam the CM with lot of service requests.
It should look something like the below