Add support for connecting to websocket through proxy #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, |
skjernaa
reviewed
Oct 7, 2022
| wsAddProxy(private$wsObj, proxyUrl) | ||
|
|
||
| if (!is.null(proxyUsername)) { | ||
| if (is.null(proxyPassword)) |
|
This would be great to have fixed (including Skjernaa's fix above). Any progress here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request exposes three new parameters to the websocket constructor:
An alternative approach would be to check and respect the settings given by the
http_proxy,https_proxyenvironment variables. However, some proxies do not support websockets, so this might leave some users in a bad state, where they have to change these environment variables back and forth when connecting to the websocket.