✨ Limit max_response_size (backport 0.2) #447
Merged
+275
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Please note:_ this only limits the size per response. It does _not_ limit how many unhandled responses may be stored on the responses hash.
Note that this cherry-picked commit is missing key paits that are incompatible with net-imap before 0.4. I'm keeping the conflict resolution here, and the updates for net-imap 0.3 in the next commit. ------ Though it would be useful to also have limits based on response type and what commands are currently running, that's out of scope for now. _Please note:_ this only limits the size per response. It does _not_ limit how many unhandled responses may be stored on the responses hash.
nevans
changed the title
For the net-imap v0.3 backport, two major changes were needed: * the tests needed to be almost completely rewritten because FakeServer was added for v0.4. * `max_response_size` needed to be on Net::IMAP directly, because Config was added for v0.4.
nevans
force-pushed
the
backport/v0.2-max_response_size
branch
from
7d22a6a to
673cab8
Compare
nevans
added
enhancement
headius
added a commit
to headius/jruby
that referenced
this pull request
May 5, 2025
* ruby/net-imap#442 * ruby/net-imap#447 The security advisory is at GHSA-j3g3-5qv5-52mj See https://github.com/ruby/net-imap/releases/tag/v0.2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #444 to
v0.2-stable.