🐛 Fix SequenceSet#slice when length > result size
#459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
changed the base branch from
sequence_set/fix-xor-should-not-modify-self
to
master
nevans
force-pushed
the
sequence_set/fix-slice-longer-than-remainder
branch
2 times, most recently
from
3aedace to
b2ab546
Compare
The goal is for `#[]` (aliased as `#slice`) to behave similarly to `Array#[]`/`Array#slice`. When `Array#slice` has a length or range that extends beyond the end of the array, they simply return everything up to the end.
nevans
force-pushed
the
sequence_set/fix-slice-longer-than-remainder
branch
from
b2ab546 to
023f3c4
Compare
nevans
changed the title
SequenceSet#slice when length > result size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is for
#[](aliased as#slice) to behave similarly toArray#[]/Array#slice. WhenArray#slicehas a length or range that extends beyond the end of the array, they simply return everything up to the end.