Skip to content

Set language in HTML #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Set language in HTML #1361

merged 1 commit into from
May 6, 2025

Conversation

p8
Copy link
Contributor

@p8 p8 commented May 5, 2025

Setting the language helps with search engines, screen readers and text rendering. The language defaults to en as that is probably most common (it's also the default for navigation in Darkfish).

Setting the locale option will override the language to the locale.

@p8 p8 force-pushed the features/html-lang branch 3 times, most recently from 0df9507 to 498311f Compare May 5, 2025 16:52
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Setting the language helps with search engines, screen readers and text
rendering. The language defaults to `en` as that is probably most common
(it's also the default for navigation in Darkfish).

Setting the `locale` option will override the language to the locale.

Co-authored-by: Vinicius Stock <[email protected]>
@p8 p8 force-pushed the features/html-lang branch from 498311f to c0438ac Compare May 6, 2025 08:21
@vinistock vinistock merged commit 8417536 into ruby:master May 6, 2025
29 of 30 checks passed
@p8 p8 deleted the features/html-lang branch May 6, 2025 17:27
@p8
Copy link
Contributor Author

p8 commented May 6, 2025

Thanks @vinistock !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants