Skip to content

fix: buildkit cache prune #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

fix: buildkit cache prune #238

merged 1 commit into from
Apr 15, 2025

Conversation

Shubhranshu153
Copy link
Contributor

@Shubhranshu153 Shubhranshu153 commented Apr 15, 2025

Issue #, if available:

Description of changes:
Fix test to check buildkit cache is cleared on prune

Testing done:
Tested locally to confirm builder prune is able to remove dangling build cache.

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Shubhranshu153 Shubhranshu153 force-pushed the fix-buildkit-cache-prune branch 3 times, most recently from 162a8cb to 1ad4f80 Compare April 15, 2025 21:21
@Shubhranshu153 Shubhranshu153 requested a review from a team April 15, 2025 21:22
@Shubhranshu153 Shubhranshu153 marked this pull request as ready for review April 15, 2025 21:22
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix, left a few minor comments

@Shubhranshu153 Shubhranshu153 force-pushed the fix-buildkit-cache-prune branch from 1ad4f80 to 1a41baa Compare April 15, 2025 23:26
@Shubhranshu153 Shubhranshu153 enabled auto-merge (squash) April 15, 2025 23:35
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
@Shubhranshu153 Shubhranshu153 force-pushed the fix-buildkit-cache-prune branch from 1a41baa to 9fda072 Compare April 15, 2025 23:41
@Shubhranshu153 Shubhranshu153 merged commit 2de9f46 into main Apr 15, 2025
3 checks passed
@Shubhranshu153 Shubhranshu153 deleted the fix-buildkit-cache-prune branch April 15, 2025 23:42
Shubhranshu153 added a commit that referenced this pull request Apr 16, 2025
Shubhranshu153 added a commit that referenced this pull request Apr 16, 2025
This reverts commit 2de9f46.

Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153 added a commit that referenced this pull request Apr 16, 2025
This reverts commit 2de9f46.

Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153 added a commit that referenced this pull request Apr 17, 2025
This reverts commit 2de9f46.

Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants