-
Notifications
You must be signed in to change notification settings - Fork 16
fix: buildkit cache prune #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
162a8cb
to
1ad4f80
Compare
pendo324
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find and fix, left a few minor comments
1ad4f80
to
1a41baa
Compare
pendo324
approved these changes
Apr 15, 2025
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
1a41baa
to
9fda072
Compare
Shubhranshu153
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 2de9f46.
Shubhranshu153
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 2de9f46. Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 2de9f46. Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153
added a commit
that referenced
this pull request
Apr 17, 2025
This reverts commit 2de9f46. Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix test to check buildkit cache is cleared on prune
Testing done:
Tested locally to confirm builder prune is able to remove dangling build cache.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.