Added globalNetwork as a flag #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the globalNetwork flag to allow globalNetworking to be enable (when applicable) throught the CLI tool. (Fix for runpod#190)
|
Also added --publicIP in the latest push. Can move these two into different pull requests if that is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added globalNetwork as a flag
This patch adds the
globalNetworkflag to allow global networking to be enable (when applicable) throught the CLI tool. This was not previously possible and I did not understand why so I just quickly fixed it and thought that someone else might also need this.(Fix for #190)
How I tested it
I tested it by creating two pods using the following commands:
Then testing if the two pods could ping each other as per the global networking documentation