This repository was archived by the owner on Nov 28, 2023. It is now read-only.
link.x: Add .sdata2 sections #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang doesn't seem to generate these, but GCC does. I'm trying to link secp256k1, which is a C library, to my Rust code so the linker script needs to include these sections too.
|
Thanks! Do you mind bumping the patch-version so we can release it together with the previous fixes? |
|
Sure, added a commit that bumps the version from 0.6.0 to 0.6.1 |
|
Thanks! |
bors bot
added a commit
that referenced
this pull request
Aug 8, 2019
38: link.x: Add .sdata2 sections r=Disasm a=laanwj Clang doesn't seem to generate these, but GCC (8.3.0 at least) does. I'm trying to link secp256k1, which is a C library, to my Rust code so the linker script needs to include these sections too. Co-authored-by: Wladimir J. van der Laan <[email protected]>
Build succeeded |
richardeoin
added a commit
to richardeoin/riscv-rt
that referenced
this pull request
Jul 14, 2020
Similar to rust-embedded#38, riscv compilers may also generate 'small ro data' `.srodata` sections. This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context.
Merged
richardeoin
added a commit
to richardeoin/riscv-rt
that referenced
this pull request
Jul 15, 2020
Similar to rust-embedded#38, riscv compilers may also generate 'small ro data' `.srodata` sections. This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context.
bors bot
added a commit
that referenced
this pull request
Jul 15, 2020
61: Update link.x r=almindor a=richardeoin Similar to #38, riscv compilers may also generate 'small ro data' `.srodata` sections. This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context. Co-authored-by: Richard Meadows <[email protected]>
Disasm
pushed a commit
that referenced
this pull request
Jul 15, 2020
Similar to #38, riscv compilers may also generate 'small ro data' `.srodata` sections. This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang doesn't seem to generate these, but GCC (8.3.0 at least) does. I'm trying to link secp256k1, which is a C library, to my Rust code so the linker script needs to include these sections too.