Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fix_tests to validate cargo fix functionality #15192

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rustin170506
Copy link
Member

What does this PR try to resolve?

Close #13527

As we discussed, cargo fix should use the default target selection with cargo check.

In this PR, I modified cargo fix to no longer use all targets by default. For cargo fix --edition, it will retain the old behavior and select all targets.

How should we test and review this PR?

Unit tests

Additional information

It checked all targets.

Signed-off-by: Rustin170506 <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-cli Area: Command-line interface, option parsing, etc. Command-fix labels Feb 16, 2025
@Rustin170506 Rustin170506 force-pushed the rustin-patch-fix-targets branch from c4933a5 to d1c5bf8 Compare February 20, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. Command-fix S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo clippy and cargo clippy --fix --allow-dirty have different reports
3 participants