unix: make struct timespec non-exhaustive.
#4508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time64 changes on both GNU and Musl libcs add padding fields to timespec. This can cause compilation failures when using time64 when regular 64-bit compiles fine. Add non_exhaustive to force people to use e.g. `..Default::default()` when initializing to prevent this when the target changes.
|
Closing, as discussed most structs will be marked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #4463 time64 changes on both GNU and Musl libcs add padding fields to timespec. This can cause compilation failures when using time64 when regular 64-bit compiles fine. Add
non_exhaustiveto force people to use e.g...Default::default()when initializing to prevent sudden errors appearing when using time64.Sources
Not applicable.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
Note: this is a breaking change.