Fix bad suggestions for deref_addrof and try_err lints

[ThibsG]

Fix bad suggestions when in macro expansion for deref_addrof and try_err lints.

Fixes: #6234
Fixes: #6242
Fixes: #6237

changelog: none

r? @llogiq

[llogiq]

I only have one nit and one question, otherwise this looks good to go. 👍

[llogiq]

This change seems unrelated?

[ThibsG]

This !in_macro(expr.span) is here to prevent the use of the macro callsite for suggestion.
In this example:

macro_rules! try_validation {
    ($e: expr) => {{
        match $e {
            Ok(_) => 0,
            Err(_) => Err(1)?, // <-- lint here
        }
    }};
}

fn calling_macro() -> Result<i32, i32> {
    try_validation!(Ok::<_, i32>(5));
    Ok(5)
}

For information,err_arg.span is referring to the 1 from Err(1)?
We want the suggestion to be return Err(1) and not to be the macro call site (try_validation!(Ok::<_, i32>(5));).

[ThibsG]

Just saw #6237, it is the same kind of problem we're solving here.
If it's ok for you to fix this here, I can also work on this before we merge this.

[ThibsG]

Ok now it should be good for #6237 as well

[llogiq]

Good work! Thank you. @bors r+

[bors]

📌 Commit 83e75f9 has been approved by llogiq

[bors]

⌛ Testing commit 83e75f9 with merge d212c38...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing d212c38 to master...