Skip to content

these are already mentioned in preceding paragraph #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Jun 15, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2025

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2025
@@ -110,8 +110,8 @@ rustc-dev-guide.
It is worth emphasizing that becoming a member of the compiler team does not necessarily imply
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh seems some copy&paste slipped in. Reading again this paragraph, I think we can just trim it down to:

Suggested change
It is worth emphasizing that becoming a member of the compiler team does not necessarily imply
The most important criterion for elevation to compiler team member, in particular,
is **regular and consistent** participation. The most important criterion for elevation to
maintainer is **actively shaping the direction of the team or compiler**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants