Skip to content

Reflection and comptime goal #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 6, 2025

With the renewed general interest in reflection via the facet crate coinciding with my own experiments with reflection, and some discussions with bevy folk at the all hands, I think that this may be a good time to pursue more language reflection capabilities than size_of and align_of.

Rendered

@fu5ha
Copy link

fu5ha commented Jun 7, 2025

Wanted to point out mirror-mirror as another prior art. We made it at Embark Studios for use in our Rust game engine. It's similar to Bevy reflect in many ways, with the most interesting differences being

  • An owned opaque Value type which can be interacted with thru the same reflection apis
  • key paths as a more ergonomic way to query thru layers of a reflected type

@lqd
Copy link
Member

lqd commented Jun 14, 2025

I've added a fix in #312 for the CI failure -- as well as fixed a bug in the template that would still prevent validation without the suggested changes below.

| Teams | <!-- TEAMS WITH ASKS --> |
| Task owners | <!-- TASK OWNERS --> |
| Status | Proposed |
| Tracking issue | https://github.com/rust-lang/rust/issues/142577 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC "Tracking issue" is supposed to be the GH project goal issue where updates will be posted.

A r-l/r tracking issue instead could be:

  • others have used the following
Suggested change
| Tracking issue | https://github.com/rust-lang/rust/issues/142577 |
| Other tracking issues | [rust-lang/rust#142577] |
  • the "See also" metadata field is also documented and supposedly used to track progress with checkboxes and so on -- but I don't know if anyone has used it / tested to see if it works 😓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently working on making the errors meaningful to me 😆 then I can think about what else to do here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, the errors aren't meaningful to me either, I haven't worked in a lot of parts in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants