-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Constify Location
methods
#101030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Constify Location
methods
#101030
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4e3b9ed
constify `Location` methods
lilasta 834cab7
Add test cases for const `Location`
lilasta 767a777
Add newlines
lilasta ca55a88
Fix indent
lilasta 7b99388
Sort mod
lilasta f0b8167
Fix test (location_const_file)
lilasta a53e3ac
Change tracking issue from #76156 to #102911
lilasta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
mod location; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
use core::panic::Location; | ||
|
||
// Note: Some of the following tests depend on the source location, | ||
// so please be careful when editing this file. | ||
|
||
#[test] | ||
fn location_const_caller() { | ||
const _CALLER_REFERENCE: &Location<'static> = Location::caller(); | ||
const _CALLER: Location<'static> = *Location::caller(); | ||
} | ||
|
||
#[test] | ||
fn location_const_file() { | ||
const CALLER: &Location<'static> = Location::caller(); | ||
const FILE: &str = CALLER.file(); | ||
assert_eq!(FILE, "library/core/tests/panic/location.rs"); | ||
} | ||
|
||
#[test] | ||
fn location_const_line() { | ||
const CALLER: &Location<'static> = Location::caller(); | ||
const LINE: u32 = CALLER.line(); | ||
assert_eq!(LINE, 21); | ||
} | ||
|
||
#[test] | ||
fn location_const_column() { | ||
const CALLER: &Location<'static> = Location::caller(); | ||
const COLUMN: u32 = CALLER.column(); | ||
assert_eq!(COLUMN, 39); | ||
} | ||
scottmcm marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.