Skip to content

Async drop - fix for StorageLive/StorageDead codegen for pinned future #142347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Async drop - fix for StorageLive/StorageDead codegen for pinned future #142347

merged 1 commit into from
Jun 16, 2025
+387 −9

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Jun 11, 2025 •
edited by rustbot
Loading

Fixes: #140429, Fixes: #140531, Fixes: #141761, Fixes: #141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@azhogin
Copy link
Contributor Author

azhogin commented Jun 11, 2025

r? oli-obk

@rustbot rustbot assigned oli-obk and unassigned lcnr Jun 11, 2025
oli-obk
oli-obk reviewed Jun 11, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 11, 2025
View reviewed changes
@petrochenkov petrochenkov added the F-async_drop `#![feature(async_drop)]` label Jun 11, 2025
@azhogin azhogin force-pushed the azhogin/async-drop-storage-live-dead-fix branch from 996c127 to 189e64c Compare June 14, 2025 01:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/async-drop-storage-live-dead-fix branch from 189e64c to df2072b Compare June 14, 2025 01:41
@rust-log-analyzer

This comment has been minimized.

Sign in to view
oli-obk
oli-obk reviewed Jun 14, 2025
View reviewed changes
@azhogin azhogin force-pushed the azhogin/async-drop-storage-live-dead-fix branch from df2072b to d6a9081 Compare June 14, 2025 08:10
@oli-obk
Copy link
Contributor

oli-obk commented Jun 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 14, 2025

📌 Commit d6a9081 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2025
fmease added a commit to fmease/rust that referenced this pull request Jun 14, 2025
@fmease
Rollup merge of rust-lang#142347 - azhogin:azhogin/async-drop-storage…
ed4537b 
…-live-dead-fix, r=oli-obk

Async drop - fix for StorageLive/StorageDead codegen for pinned future

Fixes: rust-lang#140429, Fixes: rust-lang#140531, Fixes: rust-lang#141761, Fixes: rust-lang#141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.
@fmease fmease mentioned this pull request Jun 14, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142522 - fmease:rollup-t1mkos2, r=fmease
cf4477b 
Rollup of 10 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #134661 (Reduce precedence of expressions that have an outer attr)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142377 (Try unremapping compiler sources)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142509 (bump std libc dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 15, 2025
@matthiaskrgr
Rollup merge of rust-lang#142347 - azhogin:azhogin/async-drop-storage…
2595654 
…-live-dead-fix, r=oli-obk

Async drop - fix for StorageLive/StorageDead codegen for pinned future

Fixes: rust-lang#140429, Fixes: rust-lang#140531, Fixes: rust-lang#141761, Fixes: rust-lang#141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 15, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142533 - matthiaskrgr:rollup-catmreo, r=matthiaskrgr
07029f5 
Rollup of 9 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142377 (Try unremapping compiler sources)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142509 (bump std libc dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 15, 2025
@matthiaskrgr
Rollup merge of rust-lang#142347 - azhogin:azhogin/async-drop-storage…
64c8192 
…-live-dead-fix, r=oli-obk

Async drop - fix for StorageLive/StorageDead codegen for pinned future

Fixes: rust-lang#140429, Fixes: rust-lang#140531, Fixes: rust-lang#141761, Fixes: rust-lang#141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 15, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142535 - matthiaskrgr:rollup-7is2fad, r=matthiaskrgr
8d94b0d 
Rollup of 8 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142509 (bump std libc dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jun 15, 2025
@fmease
Rollup merge of rust-lang#142347 - azhogin:azhogin/async-drop-storage…
d5213f7 
…-live-dead-fix, r=oli-obk

Async drop - fix for StorageLive/StorageDead codegen for pinned future

Fixes: rust-lang#140429, Fixes: rust-lang#140531, Fixes: rust-lang#141761, Fixes: rust-lang#141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.
@fmease fmease mentioned this pull request Jun 15, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142545 - fmease:rollup-pylzhqt, r=fmease
ef2efa4 
Rollup of 9 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #134661 (Reduce precedence of expressions that have an outer attr)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #141937 (Report never type lints in dependencies)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jun 15, 2025
Merged
bors added a commit that referenced this pull request Jun 16, 2025
@bors
Auto merge of #142550 - fmease:rollup-fteyzcv, r=fmease
e314b97 
Rollup of 10 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #134661 (Reduce precedence of expressions that have an outer attr)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141937 (Report never type lints in dependencies)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142499 (Remove check run bootstrap)
 - #142543 (Suggest adding semicolon in user code rather than macro impl details)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e06196d into rust-lang:master Jun 16, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 16, 2025
rust-timer added a commit that referenced this pull request Jun 16, 2025
@rust-timer
Unrolled build for #142347
ff924a3 
Rollup merge of #142347 - azhogin:azhogin/async-drop-storage-live-dead-fix, r=oli-obk

Async drop - fix for StorageLive/StorageDead codegen for pinned future

Fixes: #140429, Fixes: #140531, Fixes: #141761, Fixes: #141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
F-async_drop `#![feature(async_drop)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
7 participants
@azhogin @rustbot @rust-log-analyzer @oli-obk @bors @petrochenkov @lcnr