Do not clone Arc when hashing span.

[cjgillot]

Tiny improvement I was when trying to profile span hashing.

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Kobzol]

@bors2 try @rust-timer queue

[rust-bors]

⌛ Trying commit a5ff3cc with merge fb07b82…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: fb07b82 (fb07b82e64a18c5e2764c980d1be979980d9df1a, parent: 14346303d760027e53214e705109a62c0f00b214)

[davidtwco]

r=me if perf turns out 🤞

[rust-timer]

Finished benchmarking commit (fb07b82): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.0%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-2.1%	[-2.4%, -1.8%]	2
All ❌✅ (primary)	0.0%	[-1.3%, 1.4%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.927s -> 756.111s (0.02%)
Artifact size: 372.13 MiB -> 372.13 MiB (-0.00%)

[cjgillot]

@bors r=davidtwco

[bors]

📌 Commit a5ff3cc has been approved by davidtwco

It is now in the queue for this repository.

[fmease]

precedence over next rollup @bors p=5

[bors]

⌛ Testing commit a5ff3cc with merge 0cbc076...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 0cbc076 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 32b5152 (parent) -> 0cbc076 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0cbc0764380630780a275c437260e4d4d5f28c92 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. mingw-check-tidy: 70.2s -> 93.3s (32.8%)
2. x86_64-apple-2: 6721.6s -> 4541.6s (-32.4%)
3. dist-apple-various: 7657.7s -> 5925.9s (-22.6%)
4. dist-x86_64-apple: 8891.0s -> 10591.1s (19.1%)
5. dist-aarch64-msvc: 9489.3s -> 8302.9s (-12.5%)
6. aarch64-apple: 5325.5s -> 4739.7s (-11.0%)
7. x86_64-gnu-stable: 8299.9s -> 7537.0s (-9.2%)
8. dist-ohos-x86_64: 4258.5s -> 3986.2s (-6.4%)
9. dist-armhf-linux: 4372.9s -> 4651.8s (6.4%)
10. x86_64-rust-for-linux: 3055.3s -> 2860.9s (-6.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (0cbc076): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.461s -> 757.399s (0.26%)
Artifact size: 372.12 MiB -> 372.20 MiB (0.02%)