Skip to content

Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism #142563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism #142563

merged 2 commits into from
Jun 17, 2025
+17 −24

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 16, 2025 •
edited
Loading

Closes #128911. This PR re-enables the dump-ice-to-disk test and the unstable feature usage metrics tests for {x86_64,i686} Windows MSVC hosts and x86_64 Windows GNU host. I'll keep an eye out for these tests, and will broaden the ignores if this test is still flaky on not just i686-pc-windows-gnu.

r? mati865

try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2025
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 16, 2025
@jieyouxu jieyouxu force-pushed the no-more-i686-mingw branch from 578b33d to e40da5b Compare June 16, 2025 23:46
@jieyouxu
Copy link
Member Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 16, 2025

⌛ Trying commit e40da5b with merge 62e4640…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of #142563 - jieyouxu:no-more-i686-mingw, r=<try>
62e4640 
[WIP] Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism

Closes #128911. This PR *re-enables* the `dump-ice-to-disk` test and the unstable feature usage metrics tests for {x86_64,i686} Windows MSVC hosts and x86_64 Windows GNU host. I'll keep an eye out for these tests, and will broaden the ignores if this test is still flaky on not just `i686-pc-windows-gnu`.

r? mati865

try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@jieyouxu jieyouxu changed the title [WIP] Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism Jun 16, 2025
@jieyouxu jieyouxu marked this pull request as ready for review June 16, 2025 23:49
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2025
@jieyouxu jieyouxu removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 16, 2025
mati865
mati865 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@mati865 mati865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once the try jobs pass.

@rust-bors
Copy link

rust-bors bot commented Jun 17, 2025

💔 Test failed

@jieyouxu
Copy link
Member Author

D'oh, should've ran this locally xD

@jieyouxu jieyouxu force-pushed the no-more-i686-mingw branch from e40da5b to aa8c6f8 Compare June 17, 2025 03:11
@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 17, 2025 •
edited
Loading

Ran this locally on msvc, but it's just the directory not found message that's platform-specific. The assertion is checking that we don't ICE, so matching on error itself is sufficient.

@bors r=mati865 rollup

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

📌 Commit aa8c6f8 has been approved by mati865

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025
@workingjubilee workingjubilee mentioned this pull request Jun 17, 2025
Merged
rust-bors bot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of #142613 - workingjubilee:rollup-yuod2hg, r=<try>
69b2373 
Rollup of 13 pull requests

Successful merges:

 - #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - #141946 (std: refactor explanation of `NonNull`)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142542 (Manually invalidate caches in SimplifyCfg.)
 - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142587 (Make sure to propagate result from `visit_expr_fields`)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)
 - #142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
<!-- homu-ignore:start -->
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=138538,141946,142216,142542,142563,142570,142584,142585,142586,142587,142595,142598,142601)
<!-- homu-ignore:end -->
try-job: dist-apple-various
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 17, 2025
@workingjubilee
Rollup merge of rust-lang#142563 - jieyouxu:no-more-i686-mingw, r=mat…
ac8a2cb 
…i865

Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism

Closes rust-lang#128911. This PR *re-enables* the `dump-ice-to-disk` test and the unstable feature usage metrics tests for {x86_64,i686} Windows MSVC hosts and x86_64 Windows GNU host. I'll keep an eye out for these tests, and will broaden the ignores if this test is still flaky on not just `i686-pc-windows-gnu`.

r? mati865

try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@workingjubilee workingjubilee mentioned this pull request Jun 17, 2025
Open
@jieyouxu jieyouxu mentioned this pull request Jun 17, 2025
Draft
rust-bors bot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of #139244 - jieyouxu:exp/auto-cross-run-make, r=<try>
ac749ee 
[WIP] Enable automatic cross-compilation in run-make tests

> [!CAUTION]
>
> Conflicts with #142563.

Supersedes #138066.

Blocker for #141856.

Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.

r? `@ghost`

try-job: armhf-gnu
try-job: test-various
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142614 - workingjubilee:rollup-g5qf7y3, r=workingjubilee
1b4aa42 
Rollup of 10 pull requests

Successful merges:

 - #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - #141946 (std: refactor explanation of `NonNull`)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142371 (avoid `&mut P<T>` in `visit_expr` etc methods)
 - #142377 (Try unremapping compiler sources)
 - #142517 (Windows: Use anonymous pipes in Command)
 - #142542 (Manually invalidate caches in SimplifyCfg.)
 - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-bors bot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of #142614 - workingjubilee:rollup-g5qf7y3, r=<try>
a62049a 
Rollup of 10 pull requests

Successful merges:

 - #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - #141946 (std: refactor explanation of `NonNull`)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142371 (avoid `&mut P<T>` in `visit_expr` etc methods)
 - #142377 (Try unremapping compiler sources)
 - #142517 (Windows: Use anonymous pipes in Command)
 - #142542 (Manually invalidate caches in SimplifyCfg.)
 - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)

r? `@ghost`
`@rustbot` modify labels: rollup
<!-- homu-ignore:start -->
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=138538,141946,142216,142371,142377,142517,142542,142563,142570,142584)
<!-- homu-ignore:end -->
try-job: dist-aarch64-apple
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142613 - workingjubilee:rollup-yuod2hg, r=workingjubilee
f3db639 
Rollup of 13 pull requests

Successful merges:

 - #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - #141946 (std: refactor explanation of `NonNull`)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142542 (Manually invalidate caches in SimplifyCfg.)
 - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142587 (Make sure to propagate result from `visit_expr_fields`)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)
 - #142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f2e9e2a into rust-lang:master Jun 17, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 17, 2025
rust-timer added a commit that referenced this pull request Jun 17, 2025
@rust-timer
Unrolled build for #142563
e36d27f 
Rollup merge of #142563 - jieyouxu:no-more-i686-mingw, r=mati865

Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism

Closes #128911. This PR *re-enables* the `dump-ice-to-disk` test and the unstable feature usage metrics tests for {x86_64,i686} Windows MSVC hosts and x86_64 Windows GNU host. I'll keep an eye out for these tests, and will broaden the ignores if this test is still flaky on not just `i686-pc-windows-gnu`.

r? mati865

try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@jieyouxu jieyouxu deleted the no-more-i686-mingw branch June 17, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mati865 mati865 mati865 approved these changes

Assignees

@mati865 mati865

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

tests/run-make/dump-ice-to-disk is flakey on i686-mingw
4 participants
@jieyouxu @bors @mati865 @rustbot