Skip to content

ci: support optional jobs #143274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

ci: support optional jobs #143274

merged 1 commit into from
Jul 2, 2025

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jul 1, 2025 •
edited
Loading

As discussed in #t-infra > Testing for T2/T3 targets @ 💬.

Add support for jobs running only on-demand (not part of the auto build or pr jobs).

r? @Kobzol

try-job: optional-mingw-check-1

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 1, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143274 - marcoieni:optional-jobs, r=<try>
0e1edb2 
ci: support optional jobs

try-job: optional-mingw-check-1
@bors
Copy link
Collaborator

bors commented Jul 1, 2025

⌛ Trying commit cee1069 with merge 0e1edb2...

Kobzol
Kobzol reviewed Jul 1, 2025
View reviewed changes
@marcoieni marcoieni marked this pull request as ready for review July 1, 2025 09:29
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2025
@marcoieni
Copy link
Member Author

looks like it's working

@rustbot ready

@Kobzol
Copy link
Member

Kobzol commented Jul 1, 2025

Thanks! You can r=me once PR CI and the try build are green.

@marcoieni
Copy link
Member Author

@bors r=Kobzol

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

📌 Commit 311a99c has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025
jieyouxu
jieyouxu reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, could we write this down somewhere in contributing docs, just so other contributors might actually discover this is a thing 😁 (Doesn't have to be in this PR)

@marcoieni marcoieni mentioned this pull request Jul 1, 2025
Merged
@marcoieni
Copy link
Member Author

done in #143283 👍

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 1, 2025
@jhpratt
Rollup merge of rust-lang#143274 - marcoieni:optional-jobs, r=Kobzol
9a07698 
ci: support optional jobs

try-job: optional-mingw-check-1
@jhpratt jhpratt mentioned this pull request Jul 1, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143305 - jhpratt:rollup-t7e7uhj, r=jhpratt
5264bc9 
Rollup of 12 pull requests

Successful merges:

 - #141829 (Specialize sleep_until implementation for unix (except mac))
 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142568 (Use the .drectve section for exporting symbols from dlls on Windows)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143206 (Align attr fixes)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025
@jhpratt
Rollup merge of rust-lang#143274 - marcoieni:optional-jobs, r=Kobzol
f609f8c 
ci: support optional jobs

try-job: optional-mingw-check-1
@jhpratt jhpratt mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143311 - jhpratt:rollup-vjx4zoy, r=jhpratt
77b41b0 
Rollup of 11 pull requests

Successful merges:

 - #141829 (Specialize sleep_until implementation for unix (except mac))
 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143206 (Align attr fixes)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025
@jhpratt
Rollup merge of rust-lang#143274 - marcoieni:optional-jobs, r=Kobzol
87a74bd 
ci: support optional jobs

try-job: optional-mingw-check-1
@jhpratt jhpratt mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143313 - jhpratt:rollup-55h4nj0, r=jhpratt
4d9342a 
Rollup of 12 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143206 (Align attr fixes)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#143274 - marcoieni:optional-jobs, r=Kobzol
e3fc977 
ci: support optional jobs

try-job: optional-mingw-check-1
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143317 - matthiaskrgr:rollup-isq1wbb, r=matthiaskrgr
28c341e 
Rollup of 11 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143038 (avoid suggesting traits from private dependencies)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#143274 - marcoieni:optional-jobs, r=Kobzol
87e28ff 
ci: support optional jobs

try-job: optional-mingw-check-1
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2025
Closed
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143322 - matthiaskrgr:rollup-h6xw7i5, r=matthiaskrgr
58dd450 
Rollup of 10 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2025
Merged
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143337 - matthiaskrgr:rollup-lqwhe0i, r=matthiaskrgr
6677875 
Rollup of 9 pull requests

Successful merges:

 - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
 - #142138 (Add `Vec::into_chunks`)
 - #142321 (Expose elf abi on ppc64 targets)
 - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
 - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
 - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
 - #143274 (ci: support optional jobs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c572231 into rust-lang:master Jul 2, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jul 2, 2025
@rust-timer
Unrolled build for #143274
840d5f3 
Rollup merge of #143274 - marcoieni:optional-jobs, r=Kobzol

ci: support optional jobs

try-job: optional-mingw-check-1
@rustbot rustbot added this to the 1.90.0 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoieni @bors @Kobzol @jieyouxu @rustbot