In documentation, hide about section when searching #5648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krtab
changed the title
ytmimi
reviewed
Jan 3, 2023
There was a problem hiding this comment.
I think giving users the option to collapse the about section would be a nice addition to the docs.
I think this functionality could be linked to searching, but perhaps a more flexible option is to provide a checkbox or another button to allow toggling the about section.
This commit hides the about section when the search bar is not empty, making it more discoverable to users that search is indeed working and they should look in the options section.
|
Feel free to add a button or checkbox on top of that. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit hides the about section when the search bar is not empty, making it more discoverable to users that search is indeed working and they should look in the options section.