Linux Raw: Clarify x86_64 linux_raw syscall number. #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
reviewed
Jun 9, 2025
src/backends/linux_raw.rs
Outdated
| // TODO(MSRV-1.78): Add `any(target_abi = "", target_abi = "x32")` above. | ||
| const __X32_SYSCALL_BIT: u32 = 1 << 30; | ||
| #[allow(clippy::assertions_on_constants)] | ||
| const _MATCHES_KERNEL_SOURCE: () = assert!(__X32_SYSCALL_BIT == 0x40000000); |
There was a problem hiding this comment.
Why not just write it as const __X32_SYSCALL_BIT: u32 = 0x40000000; ?
There was a problem hiding this comment.
Why not just write it as
const __X32_SYSCALL_BIT: u32 = 0x40000000;?
Done!
The source code didn't mention the x32 ABI by name. Give `__X32_SYSCALL_BIT` its rightful name so readers can understand what we're doing. Explain why we're not using `cfg(target_abi)`. For other ILP32 ABIs, it seems like they use the same syscall numbers.
newpavlov
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code didn't mention the x32 ABI by name. Give
__X32_SYSCALL_BITits rightful name so readers can understand what we're doing. Explain why we're not usingcfg(target_abi).For other ILP32 ABIs, it seems like they use the same syscall numbers.