Add feature to inhibit log capture #219
Conversation
This is necessary to work properly when built as a Rust dependency (a rare use case).
There was a problem hiding this comment.
Looks OK from my perspective.
Due to the additive nature of Cargo features, it might make more sense from a Rust perspective to invert this feature (log_capture) which is disabled by default, but enabled by the Makefile, but I don't see any immediate issues with doing it this way.
|
It's funny, I chose the negative flag exactly because of the additive nature of Cargo features. If crate A is expecting logs to not be captured, it shouldn't be possible for crate B somewhere else in the dependency tree to add a feature that causes logs to be captured after all. What's the way in which additivity of features advocates for using a positive feature? |
I guess I was thinking of it in an inverse way -- crate A doesn't really have any expectations at all about logs, but when using it from C you want the logs to be captured. I was also thinking that if other crates were to decide to use rustls-ffi, almost universally they would want to enable But I'm fine with either way, there's an understandable logic behind the inverse feature as well. |
This is necessary to work properly when built as a Rust dependency (a
rare use case).
Fixes #212.
/cc @sagebind for review. I think this is the last thing we need before uploading rustls-ffi and making it usable as a backend for curl-rust.