rustls_error: correct output buffer length handling
#551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function does not need to keep an output buffer byte spare to zero-terminate the string, as it doesn't terminate the output. So don't do that. As an effect, this fixes the integer underflow followed by buffer overflow for `rustls_error` with an empty output buffer. `test_rustls_error_into_empty_buffer` is a regression test for that case.
djc
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function does not need to keep an output buffer byte spare to zero-terminate the string, as it doesn't terminate the output. So don't do that.
As an effect, this fixes the integer underflow followed by buffer overflow for
rustls_errorwith an empty output buffer.test_rustls_error_into_empty_bufferis a regression test for that case.(found while reviewing a use of this function in curl)