Skip to content

ordnung: Memory safety issues in compact::Vec #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

Qwaz
Copy link
Contributor

@Qwaz Qwaz commented Sep 3, 2020

compact::Vec contains multiple memory safety issues.

  1. It mishandles large capacity and causes out-of-bound access in 32-bit / allocator layout mismatch in 64-bit.
  2. remove() is not panic-safe and causes double-free when an index larger than the length is provided.

Original issue report: maciejhirsz/ordnung#8

@Shnatsel Shnatsel merged commit 0cee8f8 into rustsec:master Sep 3, 2020
@Qwaz Qwaz deleted the 0012-ordnung branch January 13, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants