Remove deprecated ioutil #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the go version - Replace the use of ioutil package readall with the os package's readall
Go mod can easily manage versions.
- Remove redundant test - Add more special cases - Remove reference to ported as it is no longer ported
alexandear
suggested changes
Nov 28, 2024
| @@ -1,5 +1,11 @@ | |||
| module github.com/sabhiram/go-gitignore | |||
| module github.com/Diogenesoftoronto/go-gitignore | |||
There was a problem hiding this comment.
I think we should not change the module name:
Suggested change
| module github.com/Diogenesoftoronto/go-gitignore | |
| module github.com/sabhiram/go-gitignore |
There was a problem hiding this comment.
I'm not sure we need to refactor tests in this PR. Better is to create a separate PR.
|
|
||
| go 1.13 | ||
| go 1.22 |
There was a problem hiding this comment.
Maybe we can leave the minimum possible version the library is compiled with:
Suggested change
| go 1.22 | |
| go 1.16 |
|
Duplicates #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I don't know if anyone is here to review this but I just thought that I would update this package with some simple updates. I was using it myself and I might add some improvement on top of this if that is okay :)