Skip to content

Add empty host and leading slash to Windows file paths #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 19, 2022

  1. add an explicit unit test for issue Windows file prefix #31
  2. Adjust README to mention Windows-style paths
  3. Add empty host and leading slash to Windows file paths (this is a remake of PR Add empty host and trailing slash to windows file paths #71
  4. changelog and version bump to 3.0.0

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #82 (df6803e) into master (50c2f98) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   98.49%   98.54%   +0.04%     
==========================================
  Files           1        1              
  Lines         133      137       +4     
==========================================
+ Hits          131      135       +4     
  Misses          2        2              
Impacted Files Coverage Δ
lib/functions.php 98.54% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis requested a review from staabm September 19, 2022 08:58
@phil-davis phil-davis mentioned this pull request Sep 19, 2022
@phil-davis
Copy link
Contributor Author

phil-davis commented Sep 19, 2022

Wait until we decide the final actions to resolve issue #81 because maybe the text here will only apply to the next major release.

@phil-davis phil-davis self-assigned this Sep 19, 2022
@phil-davis phil-davis marked this pull request as draft September 19, 2022 09:01
@phil-davis phil-davis changed the title Adjust README to mention Windows-style paths Add empty host and leading slash to Windows file paths Sep 19, 2022
@phil-davis phil-davis marked this pull request as ready for review September 19, 2022 15:34
@phil-davis
Copy link
Contributor Author

phil-davis commented Sep 19, 2022

I will finish this tomorrow - give people a few hours to point out any errors I might have made in the releases 2.2.4 and 2.3.2

@phil-davis
Copy link
Contributor Author

A week has passed - let's get moving again!

@phil-davis phil-davis merged commit cbf3510 into sabre-io:master Sep 26, 2022
@phil-davis phil-davis deleted the readme-parse-url branch September 26, 2022 06:03
@staabm
Copy link
Member

staabm commented Sep 26, 2022

all good - thanks for working on it phil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants