Skip to content

Revert 71 and adjust test scenarios #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 19, 2022

After merging this, I can make a patch release to put the behavior back.

Then I can apply the fix again, and do a major version release.

@phil-davis phil-davis requested a review from staabm September 19, 2022 10:20
@phil-davis phil-davis self-assigned this Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #83 (80541a2) into master (2ec3dce) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   98.54%   98.49%   -0.05%     
==========================================
  Files           1        1              
  Lines         137      133       -4     
==========================================
- Hits          135      131       -4     
  Misses          2        2              
Impacted Files Coverage Δ
lib/functions.php 98.49% <ø> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis merged commit 3e0acf0 into sabre-io:master Sep 19, 2022
@phil-davis phil-davis mentioned this pull request Sep 19, 2022
@phil-davis phil-davis deleted the revert-71 branch September 19, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants