pkgs/sage-conf_pypi: Skip configure/make when SAGE_CONF_FILE or SAGE_CONF_ENV_FILE are set
#37620
Conversation
|
@kiwifb Is this roughly what would enable you to use sage-conf from PyPI? |
|
I'll have to try it, but on the description, that would avoid most of the patching I do. That could motivate me, to fix all the issues that come with trying to ship the |
pkgs/sage-conf_pypi/setup.py
Outdated
| else: | ||
| # build_scripts skips empty files, so create something nonempty | ||
| with open(os.path.join(HERE, 'bin', 'sage-env-config'), 'w') as f: | ||
| print("# -*- shell-script -*-", file=f) |
There was a problem hiding this comment.
I am perfectly happy with it being skipped. I am currently not shipping this file in any way shape or form and everything is fine. The main consumer at runtime is the sage script and it can cope with it not being present
Line 176 in e417e22
So, I'd rather skip it rather than having a token file.
There was a problem hiding this comment.
The problem is that after skipping the installation, setuptools gives an error because the file is named in the metadata but is not present...
There was a problem hiding this comment.
Probably why I currently remove it from setup.cfg. I must have seen that error some time ago. I guess, that acceptably would avoid the patching then.
There was a problem hiding this comment.
I'd rather skip it rather than having a token file.
Done in d85432a
There was a problem hiding this comment.
Let's get this in please.
|
Documentation preview for this PR (built with commit 7ccab80; changes) is ready! 🎉 |
mkoeppe
force-pushed
the
sage_conf_merge
branch
2 times, most recently
from
54e22ea to
97de68a
Compare
mkoeppe
force-pushed
the
sage_conf_merge
branch
from
97de68a to
26dbbfb
Compare
mkoeppe
force-pushed
the
sage_conf_merge
branch
from
a192a46 to
cc26a34
Compare
mkoeppe
force-pushed
the
sage_conf_merge
branch
from
cc26a34 to
8d458bf
Compare
mkoeppe
changed the title
SAGE_CONF_FILE or SAGE_CONF_ENV_FILE are setpkgs/sage-conf_pypi: Skip configure/make when SAGE_CONF_FILE or SAGE_CONF_ENV_FILE are set
… do not run configure/make
…ONF_ENV_FILE=/dev/null
mkoeppe
force-pushed
the
sage_conf_merge
branch
from
8d458bf to
6376b50
Compare
The distribution package sage-conf as found on PyPI is the version from pkgs/sage-conf_pypi, which creates a SAGE_ROOT and then runs
configureandmake.Here we make the same distribution package usable in a different way: Set
SAGE_CONF_FILEor/andSAGE_CONF_ENV_FILEto whatever static file has your configuration, or just/dev/null, and that will be taken.This may be a useful simplification for downstream packagers.
We also add another environment variable:
SAGE_CONF_CONFIGURE_ARGSand add some documentation.📝 Checklist
⌛ Dependencies