Skip to content

workflows: fix pushing to registry on sched builds #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

phlogistonjohn
Copy link
Collaborator

Copy and pasted from the yaml file in samba-containers, so I assume its good. :-)

Signed-off-by: John Mulligan [email protected]

@phlogistonjohn phlogistonjohn marked this pull request as ready for review May 26, 2022 14:07
@phlogistonjohn phlogistonjohn requested review from spuiuk and synarete May 26, 2022 14:07
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -21,7 +21,7 @@ jobs:

push:
runs-on: ubuntu-latest
if: github.event_name == 'push'
if: (github.event_name == 'push' || github.event_name == 'schedule') && github.repository == 'samba-in-kubernetes/sambacc'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@anoopcs9 anoopcs9 merged commit cf95bd1 into master May 27, 2022
@anoopcs9 anoopcs9 deleted the jjm-reg-push-fix branch May 27, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants