tox.ini: avoid one tox warning when running py3-mypy #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obnoxxx
requested changes
Nov 22, 2022
tox.ini
Outdated
| [testenv:py3] | ||
| # In order to run tests that rely on "system level" packages (samba, | ||
| # xattr, etc.), and not have a lot of test skips, we have to enable the | ||
| # sitepackages option. However when it is eanbled and you already have a tool |
There was a problem hiding this comment.
Suggested change
| # sitepackages option. However when it is eanbled and you already have a tool | |
| # sitepackages option. However when it is enabled and you already have a tool |
There was a problem hiding this comment.
typo fixed. thanks!
Rework how the tox.ini file is organized in order to remove a `command found but not installed in testenv` when running tox. We currently need at least one test run to be executed with system site packages enabled, but we don't need it that way for mypy. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-one-less-warning
branch
from
e83329c to
48ca5c3
Compare
obnoxxx
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how the tox.ini file is organized in order to remove a
command found but not installed in testenvwhen running tox. We currently need at least one test run to be executed with system site packages enabled, but we don't need it that way for mypy.