Skip to content

docs: fix incorrect version number in configuration.md #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Mar 3, 2023

Fix the version given for the samba-container-config key. The code and examples were correct but the docs had "v1" was was an error I made when first writing the doc.

Fixes: #66

Fix the  version given for the samba-container-config key. The
code and examples were correct but the docs had "v1" was was an
error I made when first writing the doc.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn
Copy link
Collaborator Author

@dmulder FYI

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@phlogistonjohn phlogistonjohn merged commit bc579c9 into samba-in-kubernetes:master Mar 9, 2023
@phlogistonjohn phlogistonjohn deleted the jjm-fix-version-doc branch April 5, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sambacc/docs/configuration.md confusing samba-container-config instructions
2 participants