support moving ctdb enabled pods to new addresses #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot my own advice against persisting booleans and so the first step to teaching this code to do more than *just* add nodes is to convert the "in_nodes" bool to a state value. Signed-off-by: John Mulligan <[email protected]>
Coulda sworn I ran 'black' on this before, but apparently not? Signed-off-by: John Mulligan <[email protected]>
This is a unique, opaque(ish) string that disambiguates a node outside of the pnn. Signed-off-by: John Mulligan <[email protected]>
The identity of a node helps us track the logical cluster member outside of the strict pnn/node-ip needed by ctdb. Signed-off-by: John Mulligan <[email protected]>
If the IP is different the state will be set to "changed" so that we can update ctdb nodes file later. Signed-off-by: John Mulligan <[email protected]>
Instead of only adding nodes, the command can now update an existing entry in the state file. Signed-off-by: John Mulligan <[email protected]>
The idea is that we end up removing/replacing the ctdb node line if our container based node gets a new IP address. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-ctdb-replace
branch
from
67e2bdb to
91075b1
Compare
|
Still pending on me. Please give me another couple of days. |
spuiuk
approved these changes
Sep 13, 2021
Thanks! I do appreciate it. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pod that acts as a CTDB node may be migrated/restarted/or otherwise change IP address. Tweaking our approach to populating the nodes file we can update the CTDB cluster to use the node with it's new address.
Please review by 2021-09-09