Internal transaction position offers full ordering #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The transaction hash is the longes field among the transfer data, do not store it also as a key.
* Assign incrementing internal tx position for all transfers within the same transaction. This creates full ordering within this transaction. * What we did before was, increment this internal transaction position counter only when multiple transfers are present for same 'from-to'. * The previous behavior does not give information on which transfer is to be handled first when one address interacts with more than one other addresses.
YordanPavlov
commented
Apr 25, 2025
| @@ -23,7 +23,7 @@ export function transactionOrder(a: ETHTransfer | EOB, b: ETHTransfer | EOB) { | |||
| return internalTxPositionA - internalTxPositionB | |||
| } | |||
|
|
|||
| const ethTransferKey = (transfer: ETHTransfer) => `${transfer.blockNumber}-${transfer.transactionHash ?? ''}-${transfer.transactionPosition ?? ''}-${transfer.from}-${transfer.to}` | |||
| const ethTransferKey = (transfer: ETHTransfer) => `${transfer.blockNumber}-${transfer.transactionHash ?? ''}` | |||
There was a problem hiding this comment.
The main change.
YordanPavlov
commented
Apr 25, 2025
| await this.sendData(events, 'transactionHash', signalRecord); | ||
| } else if (BLOCKCHAIN === 'eth') { |
There was a problem hiding this comment.
Since we do not use the Kafka record key for now, storing the transaction id there is redundant and wastes spaces.
WonderBeat
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(block number, transaction id, from, to)we would increment the internal transaction position to create uniqueness. The new field would remain 0 otherwise.(block number = 10, transaciton id = "tx id", from = "A", to = "B")and(block number = 10, transaciton id = "tx id", from = "C", to = "A")the two changes on the assets of A are in no relation.
(block number, transaction id). The order matches the order received from the Node.