Skip to content

my fix to issue#30 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

my fix to issue#30 #34

wants to merge 2 commits into from

Conversation

crweller
Copy link
Contributor

see my comment on issue#30

Start/stop SAP instances in the right order.

@rhmk
Copy link
Member

rhmk commented May 16, 2025

LGTM

Copy link

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Consider cutting down line length in future if you repeat some code like this.

- name: Prepare - Sort sap_facts_register by sap_control_instance_type_sortorder
  ansible.builtin.set_fact:
    sorted_sap_facts: "{{ (sorted_sap_facts | default([]) | unique) + ( __type_list | difference(sorted_sap_facts | default([]))) }}"
  loop: "{{ sap_control_instance_type_sortorder | reverse if funct_type == 'stop' else sap_control_instance_type_sortorder }}"
  vars:
    __type_list: "{{ sap_facts_register.ansible_facts.sap | selectattr('TYPE', 'equalto', item) | list }}"
  when: 
    - __type_list | length > 0

@crweller
Copy link
Contributor Author

Thanks, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants