[SAP] Allow FCD migration to down pools #247
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the SAPDownFilter to allow pools to pass the filter if the pool is down if and only if the operation on the volume is migrate and find_backend_for_connector. This will allow a volume to be migrated from 1 vcenter to another to the same pool/datastore when the target pool is down/drain. It will require to removal of the pool_state extra spec in the volume type, otherwise the capabilities filter will drop the pool. Change-Id: I9bd6119bb3d7203bf2358c317e2699fac6730337
|
Still need to verify the source/target backend is FCD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the SAPDownFilter to allow pools to pass the filter if the pool is down if and only if the operation on the volume is migrate and find_backend_for_connector.
This will allow a volume to be migrated from 1 vcenter to another to the same pool/datastore when the target pool is down/drain. It will require to removal of the pool_state extra spec in the volume type, otherwise the capabilities filter will drop the pool.
Change-Id: I9bd6119bb3d7203bf2358c317e2699fac6730337