Skip to content

Fix: Replaced import logic in predef script for Mill projects #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

lefou
Copy link
Member

@lefou lefou commented Dec 14, 2022

The $MILL_BIN_PLATFORM replacement is only supported when used with import $ivy.

Fix issues introduced in #2821

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 82.28% // Head: 82.28% // No change to project coverage 👍

Coverage data is based on head (71040bf) compared to base (183b757).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2823   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files         148      148           
  Lines        2840     2840           
  Branches      204      204           
=======================================
  Hits         2337     2337           
  Misses        503      503           
Impacted Files Coverage Δ
...org/scalasteward/core/buildtool/mill/MillAlg.scala 78.94% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lefou lefou marked this pull request as ready for review December 14, 2022 07:19
@fthomas fthomas merged commit 642b410 into scala-steward-org:main Dec 14, 2022
@fthomas fthomas added this to the 0.17.0 milestone Dec 14, 2022
@fthomas fthomas added the bug Something isn't working label Dec 14, 2022
@lefou lefou deleted the fix-mill branch December 14, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants