test(k8s): reorder CheckDestroy #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2227 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 213 213
Lines 33753 33753
=======================================
Hits 24734 24734
Misses 6893 6893
Partials 2126 2126 ☔ View full report in Codecov by Sentry. |
Mia-Cross
force-pushed
the
k8s_tests_reorder_sweepers
branch
from
97138d3 to
685300d
Compare
Mia-Cross
changed the title
remyleone
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix the random deletion errors in the nightly tests, we should declare the CheckDestroy functions in the order they should be called.
Also TestAccScalewayK8SCluster_PoolPrivateNetwork serves no purpose now that all clusters must have a private network.