feat(object): bucket policy takes on bucket's region #2229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
force-pushed
the
object_bucket_policy_takes_on_bucket_region
branch
3 times, most recently
from
c12fd00 to
fcdba1e
Compare
|
This behavior will be generalized to all resources that can be linked to an object_bucket. More PRs will follow (ideally one per resource) to make the region easily customizable in the tests and implement this feature. Also, recent changes in the Scaleway S3 API broke some nightly tests so these PRs shall fix the problems resource by resource. |
Mia-Cross
force-pushed
the
object_bucket_policy_takes_on_bucket_region
branch
2 times, most recently
from
1f866bb to
3893241
Compare
…ult region if not explicit
Mia-Cross
force-pushed
the
object_bucket_policy_takes_on_bucket_region
branch
from
11e63e8 to
e9d9408
Compare
remyleone
reviewed
Nov 27, 2023
remyleone
approved these changes
Nov 27, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1934
The documentation on the
object_bucket_policyresource lists theregionas an attribute rather than an argument, so it does not have to be given. But if it's not the case, Terraform will try to create the policy in the default regionfr-par, which only works if the bucket is also infr-par.This PR makes the
object_bucket_policyresource have a similar behavior as thek8s_poolresource which takes on the region of the cluster. Here the policy will take on the region of the bucket it is attached to (if not explicitly given by the user).It was also necessary to change up a bit the
testAccCheckScalewayObjectBucketExistsfunction as it was only looking for buckets infr-parregion.