chore(rdb): remove deprecated packages #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
added
dependencies
rdb
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 73.30% 73.31% +0.01%
==========================================
Files 213 213
Lines 33753 33753
==========================================
+ Hits 24742 24746 +4
+ Misses 6885 6881 -4
Partials 2126 2126 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usage of deprecated package
ioutilbyioandresourcebyretry.The only deprecated elements left in the rdb area are the
endpoint_ipandendpoint_portfields (because instance.Endpoint is deprecated in the rdb API), should they be removed now also ?EDIT: just noticed that there already was an issue open for this particular topic (#1377) so this belongs in another PR.