-
Notifications
You must be signed in to change notification settings - Fork 131
fix(rdb): update endpoints handling #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Examples :
--> Defines an IPAM configured private network endpoint
--> Defines a static private network endpoint and a load_balancer public endpoint
--> Defines a default load_balancer public endpoint |
0b27797
to
f8a65c8
Compare
5ad7942
to
e3c51a2
Compare
e3c51a2
to
903ab5a
Compare
9438fe0
to
ce3a02f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2308 +/- ##
==========================================
- Coverage 73.64% 73.62% -0.02%
==========================================
Files 218 218
Lines 33848 33866 +18
==========================================
+ Hits 24928 24935 +7
- Misses 6787 6797 +10
- Partials 2133 2134 +1 ☔ View full report in Codecov by Sentry. |
This PR changes the way endpoints are handled to integrate the latest changes in the RDB API: if a private network is defined, there is no more default public endpoint. So if the user wants both a private and a public endpoint, they must explicitly declare a
load_balancer {}
empty block alongside theprivate_network
. This also means there is no need for thedisable_public_endpoint
field anymore.Closes #2281
Also there was a problem with the updates of private network endpoints, that did not always use IPAM as they should.
Closes #2299
The PR should also fix the nightly tests.