Skip to content

fix(k8s): fix waitK8SClusterDeleted function #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mia-Cross
Copy link
Contributor

The waitK8SClusterDeleted function often causes the nightly tests to fail because of an unexpected pool_required status for the cluster at the end of the WaitForCluster call.
Since we can now pass a status argument to the WaitForCluster function, we should use this instead of checking the status ourselves.

@Mia-Cross Mia-Cross force-pushed the k8s_fix_wait_delete_cluster_function branch from 860731d to 0f5dcc5 Compare December 21, 2023 12:39
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f346ab0) 73.57% compared to head (860731d) 73.58%.
Report is 2 commits behind head on master.

❗ Current head 860731d differs from pull request most recent head 0f5dcc5. Consider uploading reports for the commit 0f5dcc5 to get more accurate results

Files Patch % Lines
scaleway/helpers_k8s.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   73.57%   73.58%           
=======================================
  Files         224      224           
  Lines       34742    34738    -4     
=======================================
- Hits        25563    25561    -2     
+ Misses       6975     6972    -3     
- Partials     2204     2205    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross self-assigned this Dec 21, 2023
@Mia-Cross Mia-Cross added the k8s Kubernetes Kapsule issues, bugs and feature requests label Dec 21, 2023
@Codelax Codelax added this pull request to the merge queue Dec 21, 2023
Merged via the queue into scaleway:master with commit 2315ffd Dec 21, 2023
@Mia-Cross Mia-Cross deleted the k8s_fix_wait_delete_cluster_function branch December 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants