Skip to content

feat(ipam): add ips datasource #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jan 9, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Jan 9, 2024
@yfodil yfodil self-assigned this Jan 9, 2024
@yfodil yfodil linked an issue Jan 9, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d1af9ac) 73.56% compared to head (1e046a8) 73.64%.

Files Patch % Lines
scaleway/data_source_ipam_ips.go 87.09% 19 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
+ Coverage   73.56%   73.64%   +0.08%     
==========================================
  Files         225      226       +1     
  Lines       34815    35002     +187     
==========================================
+ Hits        25612    25778     +166     
- Misses       6992     7008      +16     
- Partials     2211     2216       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Jan 10, 2024
Merged via the queue into scaleway:master with commit d404ec0 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple IP addresses in scaleway_ipam_ip datasource
3 participants