Skip to content

feat(rdb): read replica: fill empty values in import generation #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat(rdb): read replica: fill empty values in import generation #2355

merged 3 commits into from
Jan 11, 2024

Conversation

Mia-Cross
Copy link
Contributor

Closes #2291

@Mia-Cross Mia-Cross added enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests priority:high New features labels Jan 9, 2024
@Mia-Cross Mia-Cross self-assigned this Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (616f77d) 73.64% compared to head (9e157c9) 73.65%.

❗ Current head 9e157c9 differs from pull request most recent head e794d20. Consider uploading reports for the commit e794d20 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2355   +/-   ##
=======================================
  Coverage   73.64%   73.65%           
=======================================
  Files         226      226           
  Lines       35015    35018    +3     
=======================================
+ Hits        25788    25791    +3     
  Misses       7010     7010           
  Partials     2217     2217

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross force-pushed the rdb_rr_fix_import_generation branch from ef68e1d to 4802d24 Compare January 10, 2024 09:38
@Mia-Cross Mia-Cross marked this pull request as ready for review January 10, 2024 13:18
remyleone
remyleone reviewed Jan 10, 2024
View reviewed changes
@Mia-Cross Mia-Cross force-pushed the rdb_rr_fix_import_generation branch from a843cea to eb7b82c Compare January 10, 2024 14:05
@Mia-Cross Mia-Cross force-pushed the rdb_rr_fix_import_generation branch from eb7b82c to c2dfc61 Compare January 10, 2024 14:06
yfodil
yfodil reviewed Jan 11, 2024
View reviewed changes
@remyleone remyleone enabled auto-merge January 11, 2024 13:22
@remyleone remyleone added this pull request to the merge queue Jan 11, 2024
Merged via the queue into scaleway:master with commit dec6d7e Jan 11, 2024
@Mia-Cross Mia-Cross deleted the rdb_rr_fix_import_generation branch February 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfodil yfodil yfodil left review comments

@remyleone remyleone remyleone approved these changes

Assignees

@Mia-Cross Mia-Cross

Labels
enhancement priority:high New features rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix rdb read replica import
4 participants
@Mia-Cross @codecov-commenter @remyleone @yfodil