Skip to content

feat(ipam): filter by id & add address with cidr #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jan 12, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Jan 12, 2024
@yfodil yfodil self-assigned this Jan 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (efb40a2) 73.64% compared to head (f1c7087) 73.65%.

Files Patch % Lines
scaleway/data_source_ipam_ip.go 65.68% 27 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2362   +/-   ##
=======================================
  Coverage   73.64%   73.65%           
=======================================
  Files         226      226           
  Lines       35017    35053   +36     
=======================================
+ Hits        25790    25817   +27     
- Misses       7010     7016    +6     
- Partials     2217     2220    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Jan 15, 2024
Merged via the queue into scaleway:master with commit 538c279 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants