Skip to content

feat(domain_record): add fqdn attribute #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jan 18, 2024

close #2359

@jremy42 jremy42 force-pushed the feat/add_attribute_fqdn_in_domain_record branch from 1bca5ae to 0cafd9f Compare January 18, 2024 10:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (538c279) 73.64% compared to head (fe4b15b) 73.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2367   +/-   ##
=======================================
  Coverage   73.64%   73.64%           
=======================================
  Files         228      228           
  Lines       35218    35221    +3     
=======================================
+ Hits        25937    25940    +3     
  Misses       7048     7048           
  Partials     2233     2233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/add_attribute_fqdn_in_domain_record branch from 0cafd9f to fe4b15b Compare January 18, 2024 13:22
@Codelax Codelax added this pull request to the merge queue Jan 18, 2024
Merged via the queue into scaleway:master with commit 9a786c3 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fqdn to domain record
3 participants