Skip to content

fix(baremetal): add waiter private-network delete #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Laure-di
Copy link
Contributor

No description provided.

@Laure-di Laure-di force-pushed the fix/add-waiter-pn-delete branch 3 times, most recently from 7f38133 to 83d9d35 Compare February 13, 2024 16:45
@Laure-di Laure-di force-pushed the fix/add-waiter-pn-delete branch from 83d9d35 to 27017c5 Compare February 14, 2024 09:59
@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9923570) 73.75% compared to head (27017c5) 73.74%.
Report is 4 commits behind head on master.

Files Patch % Lines
scaleway/helpers_baremetal.go 55.55% 8 Missing and 4 partials ⚠️
scaleway/resource_baremetal_server.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2396      +/-   ##
==========================================
- Coverage   73.75%   73.74%   -0.02%     
==========================================
  Files         229      229              
  Lines       35547    35577      +30     
==========================================
+ Hits        26219    26237      +18     
- Misses       7074     7082       +8     
- Partials     2254     2258       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone changed the title fix(baremetal):add waiter private-network delete fix(baremetal): add waiter private-network delete Feb 16, 2024
@remyleone remyleone added this pull request to the merge queue Feb 16, 2024
Merged via the queue into scaleway:master with commit ee6c177 Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants