Skip to content

fix(k8s): wait for pool ready when upgrading cluster #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

Mia-Cross
Copy link
Contributor

Closes #2407

(This PR is a duplicate of #2416 that I closed before doing the update of the sdk and couldn't open again because of a force-push)

@Mia-Cross Mia-Cross added bug k8s Kubernetes Kapsule issues, bugs and feature requests labels Feb 28, 2024
@Mia-Cross Mia-Cross self-assigned this Feb 28, 2024
@Mia-Cross Mia-Cross marked this pull request as ready for review February 28, 2024 13:42
@Mia-Cross Mia-Cross force-pushed the k8s_pool_wait_upgrade branch from 5ebb4d3 to 26625c3 Compare February 28, 2024 17:42
@Mia-Cross Mia-Cross force-pushed the k8s_pool_wait_upgrade branch from e803000 to 8dfc965 Compare February 29, 2024 14:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.74%. Comparing base (1c21a3e) to head (eae186a).

Files Patch % Lines
scaleway/resource_k8s_cluster.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
- Coverage   73.74%   73.74%   -0.01%     
==========================================
  Files         229      229              
  Lines       35761    35768       +7     
==========================================
+ Hits        26371    26376       +5     
- Misses       7115     7116       +1     
- Partials     2275     2276       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Feb 29, 2024
Merged via the queue into scaleway:master with commit 5c94110 Feb 29, 2024
@Mia-Cross Mia-Cross deleted the k8s_pool_wait_upgrade branch February 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Run finished even though Kubernetes nodes are in the process of upgrading
3 participants